-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/rcbrtf
#2185
Conversation
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Re: using |
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Co-authored-by: Athan <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi!
I'll reflect the changes in the |
Yeah, for READMEs, we've trended to having the H1 be the alias, rather than a description (e.g., And we've tried to steadily refactor examples to eventually make them more amenable to code transformation, such that we can on-the-fly convert syntax from ES5 to ES6+, so we've steadily tried normalizing conventions across examples and reduced the use of unassigned variable declarations, and if needed, juxtaposing them as closely as possible to first usage. |
The replacement of |
Great. So for our future implementations too, I'll be following these transformations. |
Description
This pull request:
math/base/special/rcbrtf
, which would be the single precision equivalent formath/base/special/rcbrt
.Related Issues
None.
Questions
No.
Other
main.c
instead of usingrcbrtf.c
as the filename insrc
folder, as we are using the same convention for our recent packages.Checklist
@stdlib-js/reviewers